Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak when img onerror/onload callbacks reference img #1003

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Fix memory leak when img onerror/onload callbacks reference img #1003

merged 1 commit into from
Sep 19, 2017

Commits on Sep 16, 2017

  1. Fix memory leak when img CBs reference img 

    Storing the onerror/onload callbacks in Persistent handles means they will never be GC'ed. If those functions have references to the image, then the image will never be GC'ed either.

Fixes Automattic#785
Fixes Automattic#150 (for real)
    @zbjornson
    zbjornson committed Sep 16, 2017
    Configuration menu
    Copy the full SHA
    1f4b646 View commit details
    Browse the repository at this point in the history