Speed up fillStyle= and strokeStyle=
#1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbjornson
force-pushed
the
zb/faster-setters
branch
from
6447a72 to
b055d69
Compare
Roughly 2x performance improvement. - Don't create extra Local<FunctionTemplate> handles - Don't create any Local<FunctionTemplate> handles if the value is a string I have no idea what that test case was doing.
> The style can be either a string containing a CSS color, or a CanvasGradient or CanvasPattern object. Invalid values are ignored
zbjornson
force-pushed
the
zb/faster-setters
branch
from
b055d69 to
90bbd5d
Compare
zbjornson
commented
Jul 7, 2020
| @@ -1756,7 +1756,7 @@ describe('Canvas', function () { | |||
| var canvas = createCanvas(2, 2); | |||
| var ctx = canvas.getContext('2d'); | |||
|
|
|||
| ctx.fillStyle = ['#808080']; | |||
| ctx.fillStyle = '#808080'; | |||
There was a problem hiding this comment.
I have no idea what this test was supposed to be doing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused why I was seeing CanvasPattern show up in CPU profiles when we never use them. Turns out it's from these setters.
Roughly 2x performance improvement.
Don't create extra
Local<FunctionTemplate>handlesDon't create any
Local<FunctionTemplate>handles if the value is a stringHave you updated CHANGELOG.md?