Replace fetch api #2309
Replace fetch api #2309
Conversation
|
I will make sure that the relevant PR is made 👀 |
|
Thanks, that's a nice change. #2310 will need to land first to drop support for older versions of Node.js. |
|
This commit is important, Should I separate PR? |
lib/image.js
Outdated
|
|
||
| get.concat({ | ||
| url: val, | ||
| const request = fetch(url = val, data = { |
There was a problem hiding this comment.
This creates two new global variables, url and data. I'm guessing it was a misstake
| const request = fetch(url = val, data = { | |
| const request = fetch(val, { |
lib/image.js
Outdated
| get.concat({ | ||
| url: val, | ||
| const request = fetch(url = val, data = { | ||
| method: "POST", |
There was a problem hiding this comment.
Can you use single quotes to align with the rest of the file?
| method: "POST", | |
| method: 'POST', |
lib/image.js
Outdated
| }) | ||
|
|
||
| request.then((res) => { |
There was a problem hiding this comment.
Since request is only used once, you could chain here and remove the variable:
| }) | |
| request.then((res) => { | |
| }) | |
| .then((res) => { |
lib/image.js
Outdated
| return res.arrayBuffer() | ||
| }) | ||
| .then((data) => { | ||
| return setSource(this, data) |
There was a problem hiding this comment.
setSource doesn't return anything?
| return setSource(this, data) | |
| setSource(this, data) |
lib/image.js
Outdated
| return setSource(this, data) | ||
| }) | ||
| .catch((err) => { | ||
| return onerror(err) |
There was a problem hiding this comment.
Same here.
| return onerror(err) | |
| onerror(err) |
Also, the behaviour of onerror is that it throws if a handler hasn't been set. Before this change, that thrown was delegated to the global error handler.
Now it will instead be eaten by this promise, which I don't think is desirable.
I think that util.callbackify or process.nextTick would be best used to restore the old behaviour 🤔
There was a problem hiding this comment.
=> 93cfd2f
I'm not sure if the changes I made are correct...
YuMuuu
force-pushed
the
use-fetch-api
branch
from
51ba305
to
93cfd2f
Compare
|
lib/image.js
Outdated
| util | ||
| .callbackify( | ||
| fetch(val, { | ||
| method: 'POST', |
There was a problem hiding this comment.
I'm not sure if the changes I made are correct.
simple-get.concat method type is GET.
YuMuuu
force-pushed
the
use-fetch-api
branch
2 times, most recently
from
5213c1f
to
a2e3845
Compare
|
@LinusU I fixed it |
|
@LinusU This is just a reminder if you missed my commit. Could you please take a look at my commits I’ve done last week and merge it if it looks ok. |
zbjornson
force-pushed
the
master
branch
2 times, most recently
from
64ed3d8
to
ff0f2ab
Compare
|
@LinusU Could you please review this PR? ;; |
|
@zbjornson Could you review, as it seems that @LinusU is busy? |
|
@LinusU Could you please let me know when the pull request is expected to be merged? |
|
Sorry for being a bit slow on the feedback here... Looking at the code, I don't think that it works? Have you tested this? |
Use fetch api and remove simple-get depedency (context: #2223 (comment)).