hsl() and hsla() color parsing #501
Conversation
hsl() and hsla() color values are now supported, with corresponding unit tests. Also added rebeccapurple (from CSS Color Level 4) to the named color list.
parseNumber() was erroring out on numbers with long fractional parts.
|
To my C++-uneducated eye this LGTM (code, tests, etc.) /cc @rvagg @TooTallNate |
|
|
||
| c = 0; | ||
| if (*str == '-') | ||
| { |
There was a problem hiding this comment.
lots of inconsistencies here with brace style, some of them are with a newline and some are not; have a look through the rest of the project to find a happy place with consistency
|
This is fine by me minus all the code style inconsistencies As an explanation for that I'm guessing that there might be some copy/paste going on from another project somewhere and perhaps we should include attribution. @motiz88 is this all your own code or can we attribute (simply in a comment) parts of it elsewhere? |
Also removed parseClipped() and commented out wrapInt (now wrap_int).
|
Sorry about code style, I was honestly not paying enough attention to that. I think I did a better job now :) |
|
if it works then 👍 from me! |
Fixes #437, see also #28.
Also adds support for rebeccapurple.