Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress duplicate end events #679

Closed
wants to merge 1 commit into from

Conversation

vasili-zolotov
Copy link

The end event only needs to be raised once upon reaching EOF.

@LinusU
Copy link
Collaborator

LinusU commented Nov 25, 2015

When do you see multiple end-events? Seems like there might be a bug on the C++ side here...

@kliu12
Copy link

kliu12 commented Nov 25, 2015

We see multiple end events when streaming the following image through jpegStream():

http://placelocal-photos.s3.amazonaws.com/71675-505833-38d2ea51-e46f-c228-9c08-70da44996eca_600.png

@zbjornson
Copy link
Collaborator

@kliu12 and @vasili-zolotov can you show the code you're using so we can write a test case please?

@LinusU
Copy link
Collaborator

LinusU commented May 3, 2017

I think that this was fixed by #740, please feel free to reopen if that isn't the case

@LinusU LinusU closed this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants