Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #809 #810

Merged
merged 1 commit into from
Oct 30, 2016
Merged

fix #809 #810

merged 1 commit into from
Oct 30, 2016

Conversation

chearon
Copy link
Collaborator

@chearon chearon commented Sep 10, 2016 •
edited
Loading

See #809

@zbjornson
Copy link
Collaborator

See also #316 ... looks like it has/had the same goal?

@LinusU
Copy link
Collaborator

LinusU commented Sep 11, 2016

Hmm, would it make sense to merge restore and restoreState? That way we are sure that we don't introduce any new bugs by removing the check from restoreState

@chearon
Copy link
Collaborator Author

chearon commented Sep 11, 2016

oh yeah you're right, I didn't know about #316

@LinusU makes sense I'll update in a sec

@chearon
ignore ctx.restore() if in the initial state
8ef00a4 
calling cairo_restore on the initial state makes all drawing operations
afterwards do nothing, which does not match browser behavior

also merges save+saveState, restore+restoreState functions
@chearon
Copy link
Collaborator Author

chearon commented Oct 29, 2016

I've merged those functions as requested and updated it to be compatible with #715

@LinusU
Copy link
Collaborator

LinusU commented Oct 30, 2016

Thank you 👍

@LinusU LinusU merged commit 84d8e89 into Automattic:master Oct 30, 2016
@zbjornson
Copy link
Collaborator

Wanna close #316 since this makes it redundant? :)

@chearon chearon deleted the restore-blackhole branch October 31, 2016 00:50
@LinusU LinusU mentioned this pull request Oct 31, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chearon @zbjornson @LinusU