Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport known CA certs #2717

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Backport known CA certs #2717

merged 2 commits into from
Aug 26, 2024

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Aug 26, 2024

Description

This PR backports some SSL certificates so they are available on older devices or fix broken certificate chains.

Context: pdeCcb-6JR-p2

Fixes: #2569

Testing Instructions

Backport

  1. Install the app on the devices with SDK 24.
  2. Test these podcasts: SCP Archives, Creepy, Novara Live, If I Speak, Nutrition Facts with Dr. Greger, Jogabilidade, Regras do Jogo - Holodeck, 走神大师 | 生于游戏,助你走神的生活播客.
  3. Playing or downloading the episodes should not fail with the "insecure connection" message.

Broken chain

  1. Install the app on any device.
  2. Open the app and make sure that nothing has been played or downloaded.
  3. Play any episode from Nerdy Nocą.
  4. Download any episode from Nerdy Nocą.
  5. Playing or downloading the episodes should not fail with the "insecure connection" message.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • ~I have considered whether it makes sense to add tests for my changes`
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added the [Type] Bug Not functioning as intended. label Aug 26, 2024
@MiSikora MiSikora added this to the 7.72 milestone Aug 26, 2024
@MiSikora MiSikora requested a review from a team as a code owner August 26, 2024 10:40
@MiSikora MiSikora requested review from ashiagr and removed request for a team August 26, 2024 10:40
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 26, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit204c856
Direct Downloadpocketcasts-app-prototype-build-pr2717-204c856.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit204c856
Direct Downloadpocketcasts-automotive-prototype-build-pr2717-204c856.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit204c856
Direct Downloadpocketcasts-wear-prototype-build-pr2717-204c856.apk

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my testing 👍

@ashiagr ashiagr merged commit c9560a9 into main Aug 26, 2024
15 of 16 checks passed
@ashiagr ashiagr deleted the task/certificates branch August 26, 2024 13:09
MiSikora added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Download Failed - Failed to create a secure connection to the authors's server" for several podcasts
3 participants