[Tooling] Introduce pipelines to trigger release tasks on CI #3514

AliSoftware · 2025-01-29T21:26:34Z

Description

As part of this Project Thread: paaHJt-78B-p2, this introduces .buildkite/release-pipelines/*.yml files that will take care of calling fastlane code_freeze and similar lanes called during the release process.

Those lanes are currently called by the Release Manager on their own Mac, so the point of introducing those pipelines is to be able to instead switch to make those kicker lanes be run on CI instead.

Created pipelines

List of .buildkite/release-pipelines/*.yml files calling their associated fastlane lane during ReleaseV2 scenario:

Scenario steps update in ReleasesV2

Once this lands, we will be able to also land the companion PR in wpcom to update the Release Scenario in MC (internal ref: 171698-ghe-Automattic/wpcom) to replace the currently-manual tasks like "Call bundle exec fastlane code_freeze" and the likes with automated tasks instead—i.e. tasks that will present a clickable button on ReleasesV2 which, when clicked, will trigger those lanes on CI—thus not requiring Release Managers to run those from their personal Macs anymore.

Testing Instructions

Otherwise I think the only way to test this is during the next release process that will adopt those changes (likely during 7.82)

wpmobilebot · 2025-01-29T21:28:59Z

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.

	App Name	📱 Mobile
	Build Type	debugProd
	Commit	`ee4f481`
	Direct Download	`pocketcasts-app-prototype-build-pr3514-ee4f481.apk`

📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.

	App Name	🚗 Automotive
	Build Type	debugProd
	Commit	`ee4f481`
	Direct Download	`pocketcasts-automotive-prototype-build-pr3514-ee4f481.apk`

📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.

	App Name	⌚ Wear
	Build Type	debugProd
	Commit	`ee4f481`
	Direct Download	`pocketcasts-wear-prototype-build-pr3514-ee4f481.apk`

AliSoftware · 2025-01-30T19:51:56Z

fastlane/Fastfile

@@ -362,9 +361,7 @@ platform :android do
    version = release_version_current

    # Wrap up
-    remove_branch_protection(repository: GITHUB_REPO, branch: "release/#{version}")


This is already done later during publish_release, which is a better moment to remove the release branch protection anyway (see https://github.com/Automattic/apps-infra-plans/issues/83)

mokagio

Looking good as far as I can see.

A similar feeling to what you wrote in regards to testing this:

I think the only way to test this is during the next release process that will adopt those changes (likely during 7.82)

However, I'll say that the more of these we implement, the more confident I become because I can see the code being ported from one already real-world-tested implementation to a new one.

.buildkite/commands/release-build.sh

mokagio · 2025-01-31T00:02:14Z

.buildkite/release-pipelines/code-freeze.yml

+      echo '--- 🤖 Use bot for Git operations'
+      source use-bot-for-git
+
+      echo '--- :ruby: Setup Ruby Tools'
+      install_gems
+
+      echo '--- 🔐 Access Secrets'
+      bundle exec fastlane run configure_apply


I don't think this is something we've ever done in the release pipelines, but how do you feel about extracting these common steps in a script to source?

Could be a followup / mini-project to log and pick up once someone has time to implement consistently. Just thought I'd toss the idea there for DRYing.

Yeah, as I copy/pasted the release-pipelines/code-freeze.yml multiple times to create the other release-pipelines/ and seeing how similar they all were I thought about it too; a good idea to implement cross-repo in a subsequent iteration indeed!

mokagio · 2025-01-31T00:05:06Z

fastlane/Fastfile

+    pipeline_args = {
+      pipeline_file: 'release-builds.yml',
+      environment: {
+        RELEASE_VERSION: release_version_current
+      }
+    }
+    if is_ci?
+      buildkite_pipeline_upload(**pipeline_args)
+    else
+      buildkite_trigger_build(
+        buildkite_organization: 'automattic',
+        buildkite_pipeline: 'pocket-casts-android',
+        branch: branch_to_build,
+        **pipeline_args
+      )
+    end


Nice DRYing

mokagio · 2025-01-31T00:11:51Z

Side note: Glad you used consistent naming with - in the new pipeline files even though they don't match the lanes they call 1:1.

I feel like the confusing of seeing some files with dashes and some with underscores would be bigger than the feeling of inconsistency with the file being called lane-name.yml and the lane being lane_name.

Otherwise we get a crash trying to load the `release-toolkit`—which depends on `nokogiri`—on certain agents like `tumblr-metal` because the version of `libc.so` (`GLIBC_2.28`) required by the pre-build `nokogiri.so` lib is not found on those agents (due to an older Linux OS, iinm)

Newly detected since the update of the `rubocop` gem to a more recent version

Especially since this fastlane built-in action relies on CI env vars to check the branch instead of checking the actual git branch being checked out at the time it's called, leading to it checking the `BUILDKITE_BRANCH` value (the branch on which the pipeline was started from) even if we since called `Fastlane::Helper::GitHelper.checkout_and_pull(DEFAULT_BRANCH)` right before that to switch to a different branch…

That lane does not have a `skip_confirm:` param

- We don't need to create the next milestone via Fastfile anymore since GitHub milestones creation is now handled by ReleasesV2 - We don't want to remove the branch protection of the `release/*` branch as soon as `finalize_release` but instead only during `publish_release` (where that action was also called already)

Co-authored-by: Gio Lodi <gio@mokacoding.com>

.buildkite/release-pipelines/update-rollouts.yml

.buildkite/release-pipelines/new-hotfix-release.yml

For safety and reducing risk of injection

AliSoftware self-assigned this Jan 29, 2025

AliSoftware added [Type] Tooling Related to the Gradle build scripts and the setup or maintenance of the project build process. [Area] Tooling labels Jan 29, 2025

AliSoftware added this to the 7.82 milestone Jan 29, 2025

AliSoftware marked this pull request as ready for review January 30, 2025 19:46

AliSoftware requested a review from a team as a code owner January 30, 2025 19:46

AliSoftware requested review from mebarbosa and a team and removed request for a team January 30, 2025 19:46

AliSoftware commented Jan 30, 2025

View reviewed changes

AliSoftware mentioned this pull request Jan 30, 2025

Merge release/7.81 into main #3522

Merged

AliSoftware force-pushed the tooling/release-on-ci branch from 04a1230 to fc65e8d Compare January 30, 2025 20:56

mokagio approved these changes Jan 31, 2025

View reviewed changes

AliSoftware and others added 11 commits January 31, 2025 12:16

Introduce code-freeze release-pipeline

660160d

Use the occasion to update gems to latest version

1c701f0

Fix rubocop violation

afab138

Newly detected since the update of the `rubocop` gem to a more recent version

Refactor the release/ branch checkout logic

0ae4bdb

Clean up code-freeze.yml

15ef489

Introduce all other release-pipelines/*.yml

17bff5e

Remove extra param from update_rollouts call

8d647fd

That lane does not have a `skip_confirm:` param

Add extra newline at start of script

c3b2138

Co-authored-by: Gio Lodi <gio@mokacoding.com>

AliSoftware force-pushed the tooling/release-on-ci branch from 4439e93 to c3b2138 Compare January 31, 2025 11:17

AliSoftware commented Jan 31, 2025

View reviewed changes

.buildkite/release-pipelines/update-rollouts.yml Outdated Show resolved Hide resolved

.buildkite/release-pipelines/new-hotfix-release.yml Outdated Show resolved Hide resolved

Wrap references to env vars in quotes

ee4f481

For safety and reducing risk of injection

AliSoftware enabled auto-merge (squash) January 31, 2025 12:11

AliSoftware merged commit e00218f into main Jan 31, 2025
15 of 16 checks passed

AliSoftware deleted the tooling/release-on-ci branch January 31, 2025 12:21

AliSoftware mentioned this pull request Jan 31, 2025

[Tooling] Introduce pipelines to trigger release tasks on CI Automattic/pocket-casts-ios#2720

Merged

6 tasks

This comment was marked as spam.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tooling] Introduce pipelines to trigger release tasks on CI #3514

[Tooling] Introduce pipelines to trigger release tasks on CI #3514

AliSoftware commented Jan 29, 2025 •

edited

Loading

wpmobilebot commented Jan 29, 2025 •

edited

Loading

AliSoftware Jan 30, 2025

mokagio left a comment

mokagio Jan 31, 2025

AliSoftware Jan 31, 2025

mokagio Jan 31, 2025

mokagio commented Jan 31, 2025

This comment was marked as spam.

[Tooling] Introduce pipelines to trigger release tasks on CI #3514

[Tooling] Introduce pipelines to trigger release tasks on CI #3514

Conversation

AliSoftware commented Jan 29, 2025 • edited Loading

Description

Created pipelines

Scenario steps update in ReleasesV2

Testing Instructions

wpmobilebot commented Jan 29, 2025 • edited Loading

AliSoftware Jan 30, 2025

Choose a reason for hiding this comment

mokagio left a comment

Choose a reason for hiding this comment

mokagio Jan 31, 2025

Choose a reason for hiding this comment

AliSoftware Jan 31, 2025

Choose a reason for hiding this comment

mokagio Jan 31, 2025

Choose a reason for hiding this comment

mokagio commented Jan 31, 2025

This comment was marked as spam.

AliSoftware commented Jan 29, 2025 •

edited

Loading

wpmobilebot commented Jan 29, 2025 •

edited

Loading