Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of Year 2024: Add of end_of_year_2024 feature flag #2288

Merged
merged 1 commit into from
Oct 18, 2024
Merged

End of Year 2024: Add of end_of_year_2024 feature flag #2288

merged 1 commit into from
Oct 18, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Oct 16, 2024 •
edited
Loading

📘 Part of: #2250

Implements #2287

Nothing happens yet. The showing of the modal is a bit more complex and I'm working on refactoring it for multi-year support.

To test

  • Visit the Developer section
  • Make sure endOfYear2024 appears
  • Make sure toggle works

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Oct 16, 2024
@bjtitus bjtitus added this to the 7.76 milestone Oct 16, 2024
@bjtitus bjtitus requested a review from a team as a code owner October 16, 2024 19:48
@bjtitus bjtitus requested review from danielebogo and removed request for a team October 16, 2024 19:48
@bjtitus bjtitus changed the title Add of end_of_year_2024 feature flag End of Year 2024: Add of end_of_year_2024 feature flag Oct 16, 2024
@bjtitus bjtitus merged commit 54671e2 into trunk Oct 18, 2024
5 of 8 checks passed
@bjtitus bjtitus deleted the bjtitus/end-of-year-2024/feature-flag branch October 18, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Milestone
7.76
Development

Successfully merging this pull request may close these issues.
2 participants
@bjtitus @danielebogo