-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback 2024: Top 5 Podcasts List #2340
Conversation
Generated by 🚫 Danger |
e3168bb
to
0200de7
Compare
ee403f4
to
bedd9f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm able to see the screen.
I'm going to approve it but I have 2 questions though that can be addressed on a different PR:
• Checking the design file, the animation should have a small bounce at the end. This seems a bit too linear
• Im struggling to navigate back between the screen. It depends on where I tap, some parts is unresponsive. Did you notice it?
Woops! I meant this to be a spring. I've updated it and will probably circle back to triple check these values later this week. It looks pretty close to me as it is now.
Yeah, the ScrollView is affecting the navigation gesture handling. I'm looking into some better ways to handle this but I think this is the only view with the scrolling. For now, I've added a check for the smaller device sizes as a stop gap for now to disable the scroll view on the larger devices. |
Completes #2317
To test
endOfYear2024
feature flagChecklist
CHANGELOG.md
if necessary.