Playback 2024: Longest Episode #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .padding(.top, isSmallScreen ? 0 : 20) | ||
| VStack(alignment: .leading, spacing: isSmallScreen ? 4 : 16) { | ||
| let timeString = episode.playedUpTo.storyTimeDescriptionForSharing | ||
| Text("The longest episode you listened to was \(timeString)") |
There was a problem hiding this comment.
Is the EOY English only? No need to localize these?
| @State var fifthCover: Double = 0.08 | ||
| @State var sixthCover: Double = 0 | ||
|
|
||
| var backgroundColor = Color(hex: "#E0EFAD") |
There was a problem hiding this comment.
Does this color ever change? Can it be a let variable?
SergioEstevao
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2346
LongestEpisode.mov
LongestEpisodeSmall.mov
To test
endOfYear2024feature flagChecklist
CHANGELOG.mdif necessary.