Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback 2024: Completion Rate + Pay Wall #2350

Merged
merged 15 commits into from
Oct 30, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Oct 28, 2024

📘 Part of: #2250

Part of #2348 & #2352

Completion Rate

CompletionRate.mov
CompletionRateSmall.mov

Pay Wall

PayWall.mov
Simulator.Screen.Recording.-.iPhone.6s.-.2024-10-28.at.14.22.02.mp4

To test

Paywall

  1. Enable the endOfYear2024 feature flag & restart the app
  2. Make sure the account to No Plus
  3. Navigate to the Profile and tap Playback 2024 Prompt
  4. Navigate through the stories until you hit the Paywall screen
  5. Tap the paywall screen to advance to the end
  6. Tap the "Check out Pocket Casts Plus" button to open the upsell screen

Completion Rate Plus

  1. Set the account to "Plus" from the Developer menu screen
  2. Navigate through the stories until you hit the Completion Rate screen
  3. Make sure you see the "Plus" badge

Completion Rate Patron

  1. Set the account to "Patron" from the Developer menu screen
  2. Navigate through the stories until you hit the Completion Rate screen
  3. Make sure you see the "Patron" badge

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Oct 28, 2024
@bjtitus bjtitus added this to the 7.77 milestone Oct 28, 2024
@bjtitus bjtitus marked this pull request as ready for review October 28, 2024 20:28
@bjtitus bjtitus requested a review from a team as a code owner October 28, 2024 20:28
@bjtitus bjtitus requested review from danielebogo and removed request for a team October 28, 2024 20:28
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bjtitus few things while testing:

• Tapping on the button to present the paywall doesn't do anything. It just moves to the next card
• Tapping on the left side of the last card, doesn't navigate to the previous card
• There's a different left margin in the text for this screen:

Text left margin Video of the button not responsive and last card
Simulator Screenshot - iPhone 16 - 2024-10-29 at 16 53 38

@bjtitus bjtitus requested a review from danielebogo October 29, 2024 18:21
@bjtitus
Copy link
Contributor Author

bjtitus commented Oct 29, 2024

I fixed the interactions on the Pay Wall & Epilogue screens so they should both navigate as well as keep their working buttons.

Also adjusted the spacing about on Listening Time. I will probably come back and adjust all of these and clean the code up later on:

Simulator Screenshot - iPhone 16 - 2024-10-29 at 12 15 50 Simulator Screenshot - iPhone 6s - 2024-10-29 at 12 13 57

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjtitus thanks for fixing those points.
I think there's a problem with the bottom padding in the last card

Should the bg be edge to edge?

Simulator Screenshot - iPhone 16 - 2024-10-29 at 19 34 39

@bjtitus
Copy link
Contributor Author

bjtitus commented Oct 29, 2024

I'll probably unify these footers at some point but it should be fixed up now:

Simulator Screenshot - iPhone 16 - 2024-10-29 at 14 16 55 Simulator Screenshot - iPhone 6s - 2024-10-29 at 14 13 30

@bjtitus bjtitus requested a review from danielebogo October 29, 2024 20:18
# Conflicts:
#	podcasts/End of Year/End of Year 2024/EndOfYear2024StoriesModel.swift
#	podcasts/End of Year/End of Year 2024/EndOfYear2024Story.swift
#	podcasts/Strings+Generated.swift
#	podcasts/en.lproj/Localizable.strings
@MiSikora
Copy link

MiSikora commented Oct 30, 2024

Is the percentage in the Completion Rate story in the correct place? I think it should be in the bottom right corner of the black rectangle if it fits and above it if it doesn't.

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last card seems fixed!

@MiSikora this is what I see. @bjtitus would you mind checking it as well? I see in Figma the number is bottom/right. I will approve it for now. Let me know if this needs to be fixed here or in a separate PR.

@bjtitus
Copy link
Contributor Author

bjtitus commented Oct 30, 2024

I think it should be in the bottom right corner of the black rectangle if it fits and above it if it doesn't.

Sorry, I think my original screenshots are out of date. It's stays outside of the rectangle up to 25% and then switches inside.

# Conflicts:
#	podcasts/End of Year/End of Year 2024/EndOfYear2024StoriesModel.swift
@bjtitus bjtitus merged commit 2e88786 into trunk Oct 30, 2024
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/playback-2024/completion-rate branch October 30, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants