Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback 2024: Year over year compare #2371

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Playback 2024: Year over year compare #2371

merged 8 commits into from
Oct 31, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Oct 31, 2024 •
edited
Loading

📘 Part of: #2250

Most of #2354

This isn't quite pixel perfect with the original designs due to some issues sizing across large and small screens but I need to move on to Ratings before the week is up.

Small
Simulator Screenshot - iPhone 6s - 2024-10-31 at 10 41 49 Simulator Screenshot - iPhone 6s - 2024-10-31 at 10 43 16 Simulator Screenshot - iPhone 6s - 2024-10-31 at 10 42 37

Large
Simulator Screenshot - iPhone 16 - 2024-10-31 at 10 40 49 Simulator Screenshot - iPhone 16 - 2024-10-31 at 10 39 16 Simulator Screenshot - iPhone 16 - 2024-10-31 at 10 40 09
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-31.at.09.45.30.mp4

To test

Non-Plus User

  • Use a Non-Plus account
  • Enable the endOfYear2024 feature flag
  • Visit the Profile
  • Tap "Playback 2024" prompt
  • Tap through until you

Plus User

  • Enable Plus in the Developer Menu
  • Visit the Profile
  • Tap "Playback 2024" prompt
  • Tap through until you get to the Year over Year comparison screen for 2023 -> 2024
  • Verify layout is correct and animation plays

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus requested a review from a team as a code owner October 31, 2024 16:50
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team October 31, 2024 16:50
@bjtitus bjtitus added this to the 7.77 milestone Oct 31, 2024
@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Oct 31, 2024
@bjtitus bjtitus requested review from danielebogo and removed request for danielebogo October 31, 2024 16:50
SergioEstevao
SergioEstevao approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :shipit:

danielebogo
danielebogo approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjtitus
Merge branch 'trunk' into bjtitus/playback-2024/year-over-year-compare
52d9ed6 
# Conflicts:
#	podcasts/en.lproj/Localizable.strings
@bjtitus bjtitus merged commit aa95571 into trunk Oct 31, 2024
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/playback-2024/year-over-year-compare branch October 31, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Milestone
7.77
Development

Successfully merging this pull request may close these issues.
3 participants
@bjtitus @SergioEstevao @danielebogo