-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback 2024: Ratings #2376
Playback 2024: Ratings #2376
Conversation
# Conflicts: # podcasts/End of Year/End of Year 2024/EndOfYear2024StoriesModel.swift # podcasts/en.lproj/Localizable.strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bjtitus I get a loading error while runnig this branch. I think something happens when calling the EndOfYearStoriesBuilder.build()
.
I also left a comment about one function name.
func hasLoadedData(in dataManager: DataManager) -> Bool { | ||
dataManager.ratings.ratings == nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit confusing. If I call hasLoadedData
I'm not expecting ratings
to be nil. Can we find a better name? If it's only related to ratings I would specify that in the function name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brandon! Now it's working fine!
Fixes #2353
Ratings.mov
RatingsSmall.mov
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-31.at.22.05.03.mp4
Simulator.Screen.Recording.-.iPhone.6s.-.2024-10-31.at.22.03.56.mp4
Loading Ratings
Ratings Screen
To test
Ratings Chart
endOfYear2024
Ratings Chart
endOfYear2024
Checklist
CHANGELOG.md
if necessary.