EOY 2024: Fix header and duration issues #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
changed the title
danielebogo
requested changes
Nov 5, 2024
podcasts/End of Year/EndOfYear.swift
Outdated
| @@ -206,9 +206,13 @@ struct EndOfYear { | |||
| } | |||
| } | |||
|
|
|||
| extension EndOfYear { | |||
| static var defaultDuration = 10.seconds | |||
There was a problem hiding this comment.
As we still support the 2023 version, can we switch the duration based on the currentYear?
static var defaultDuration: TimeInterval {
switch currentYear {
case .y2024: 10.seconds
default: 7.seconds
}
}
There was a problem hiding this comment.
Done here: 51402ee
podcasts/End of Year/EndOfYear.swift
Outdated
| class StoriesHostingController<ContentView: View>: UIHostingController<ContentView> { | ||
| override var preferredStatusBarStyle: UIStatusBarStyle { | ||
| .lightContent | ||
| .darkContent |
There was a problem hiding this comment.
Same here, can we switch on the current year like above?
There was a problem hiding this comment.
Done here: 51402ee
danielebogo
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| 📘 Part of: #2250 |
|:---:|
Fixes #2385 #2386
This PR fixes three issues on the EOY 2024:
To test
Checklist
CHANGELOG.mdif necessary.