Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOY 2024: Add scale animation for completion #2406

Merged
merged 1 commit into from
Nov 7, 2024
Merged

EOY 2024: Add scale animation for completion #2406

merged 1 commit into from
Nov 7, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 7, 2024 •
edited
Loading

| 📘 Part of: #2250 |
|:---:|

Fixes #2403

animation_completed.mov

To test

  1. Start the app
  2. Ensure that you have the EOY 2024 FF enabled
  3. Tap on the EOY 2024 banner on Profile
  4. Wait/Tap until the Completion Rate Story screen
  5. Check if the completion bar animates correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the [Project] End of Year 2024 End of Year project for 2024 label Nov 7, 2024
@SergioEstevao SergioEstevao added this to the 7.77 milestone Nov 7, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review November 7, 2024 15:27
@SergioEstevao SergioEstevao requested a review from a team as a code owner November 7, 2024 15:27
danielebogo
danielebogo approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit 76782c7 into trunk Nov 7, 2024
6 of 8 checks passed
@SergioEstevao SergioEstevao deleted the eoy2024/update_completion_animation branch November 7, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Milestone
7.77
Development

Successfully merging this pull request may close these issues.

Can we animate this screen in a similar way to the ratings screen? (the bars animating from the bottom up)
3 participants
@SergioEstevao @dangermattic @danielebogo