Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback 2024: Remove duration from ending story in Playback 2024 #2421

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Nov 14, 2024

📘 Part of: #2250

Fixes #2417

Before After
Simulator.Screen.Recording.-.iPhone.16.-.2024-11-13.at.19.47.00.mp4
Simulator.Screen.Recording.-.iPhone.16.-.2024-11-13.at.19.45.30.mp4

To test

  • Tap through the Playback 2024 stories
  • On the final story with the "Thanks" scrolling text, verify that the progress bar doesn't animate.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Nov 14, 2024
@bjtitus bjtitus added this to the 7.77 ❄️ milestone Nov 14, 2024
@bjtitus bjtitus requested a review from a team as a code owner November 14, 2024 02:44
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team November 14, 2024 02:44
@bjtitus bjtitus changed the title Remove duration from ending story in Playback 2024 Playback 2024: Remove duration from ending story in Playback 2024 Nov 14, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.77 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus changed the base branch from trunk to release/7.77 November 14, 2024 02:45
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjtitus bjtitus merged commit a97d2bc into release/7.77 Nov 14, 2024
5 of 8 checks passed
@bjtitus bjtitus deleted the bjtitus/playback-2024/epilogue-zero-duration branch November 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Ending story doesn't do anything when reaching the end
3 participants