Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback 2024: Add periods to story descriptions #2426

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Playback 2024: Add periods to story descriptions #2426

merged 1 commit into from
Nov 15, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Nov 15, 2024 •
edited
Loading

📘 Part of: #2250

Fixes #2423

Adds periods to all description text in the 2024 stories
Simulator Screenshot - iPhone 16 - 2024-11-14 at 17 14 08 Simulator Screenshot - iPhone 16 - 2024-11-14 at 17 14 12 Simulator Screenshot - iPhone 16 - 2024-11-14 at 17 14 19 Simulator Screenshot - iPhone 16 - 2024-11-14 at 17 14 21 Simulator Screenshot - iPhone 16 - 2024-11-14 at 17 20 40

To test

  • Tap through the 2024 stories
  • Verify that there are periods at the end of all descriptions in the stories

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus requested a review from a team as a code owner November 15, 2024 00:13
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team November 15, 2024 00:13
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 15, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 7.77 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Nov 15, 2024
@bjtitus bjtitus modified the milestones: 7.78, 7.77 ❄️ Nov 15, 2024
@bjtitus bjtitus force-pushed the bjtitus/playback-2024/description-periods branch from 10b5c0d to 0db8d20 Compare November 15, 2024 00:24
@bjtitus bjtitus changed the title Add periods to story descriptions Playback 2024: Add periods to story descriptions Nov 15, 2024
SergioEstevao
SergioEstevao approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjtitus bjtitus merged commit 50039da into release/7.77 Nov 15, 2024
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/playback-2024/description-periods branch November 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Milestone
7.77
Development

Successfully merging this pull request may close these issues.
3 participants
@bjtitus @dangermattic @SergioEstevao