Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to control auto-downloads on follow #2493

Merged
merged 11 commits into from
Dec 3, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 29, 2024

| 📘 Part of: #2284 |
|:---:|

Fixes #

This PR updates the AutoDownload settings to explicit say if auto-downloads on follow are active or not.
It also separate the number of downloads on subscribe from the auto-download new episode limits.
It always be two episode downloaded.

To test

  1. Start the app
  2. Go to Profile -> Downloads -> Auto-Download Settings
  3. Check if you have the option New Episodes enabled, if not enable it
  4. Check if you see the option On Follow
  5. Enable the switch
  6. Go to Discovery and find a podcast you don't follow
  7. Subscribe to it
  8. Check if you see a maximum of auto-downloads, depending on the limit set, happening for the podcast
  9. Go back to Profile -> Downloads -> Auto-Download Settings
  10. This time disable On Follow
  11. Go to Discovery and find a podcast you don't follow
  12. Subscribe to it
  13. Check if you don't see auto-downloads happening for the podcast

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the Auto Download Auto Download Feature label Nov 29, 2024
@SergioEstevao SergioEstevao added this to the 7.78 milestone Nov 29, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 29, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.78. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review November 29, 2024 16:37
@SergioEstevao SergioEstevao requested a review from a team as a code owner November 29, 2024 16:37
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team November 29, 2024 16:37
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correctly!

@SergioEstevao SergioEstevao merged commit 02ac800 into release/7.78 Dec 3, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the add_on_follow_auto_download_setting branch December 3, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto Download Auto Download Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants