Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] Use the proxy in the audio callback #2495

Merged

Conversation

danielebogo
Copy link
Contributor

Rel #2420

This PR should fix the crash happening in the DefaultPlayer by using the new proxy for the audio callback

To test

  • CI must be 🟢
  • Try to play and change episodes while playing
  • When the system decides to finalize the tap you will see 2 logs in this order:
  1. The log from the finalize closure: [AudioProcessingTapProxy] Finalize tap: <MTAudioProcessingTap 0x6000030513b0> Retain count 3 Created with i/f/p/u/t callbacks = {0x10aa14448/0x10aa14600/0x10aa149b4/0x10aa14d08/0x10aa15330} flags = 0x1
  2. The log from the proxy deinit: [AudioProcessingTapProxy] Deinit proxy
  • Switch the FF off to check everything still works as before

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the [Type] Bug Used for issues where something is not functioning as intended. label Dec 2, 2024
@danielebogo danielebogo added this to the 7.79 milestone Dec 2, 2024
@danielebogo danielebogo requested a review from a team as a code owner December 2, 2024 15:00
@danielebogo danielebogo requested review from SergioEstevao and bjtitus and removed request for a team December 2, 2024 15:00
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Checked streaming an episode with and without effects enabled
✅ Checked playing a downloaded episode with and without effects enabled

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@danielebogo danielebogo merged commit 7c483b0 into trunk Dec 3, 2024
5 of 8 checks passed
@danielebogo danielebogo deleted the danieleb/issues/fix-default-player-audio-callback-crash branch December 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants