Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Long chapter title get truncated #2499

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

leandroalonso
Copy link
Member

Fixes #1522

Removes the limit of two lines from the chapter cell.

Showing chapters Selecting them
Simulator Screenshot - iPhone 16 Pro - 2024-12-03 at 18 32 35 Simulator Screenshot - iPhone 16 Pro - 2024-12-03 at 18 32 43

To test

  1. Play an episode with chapters (eg.: any episode from Clublife)
  2. ✅ Go to chapters, ensure chapters that require more than 2 lines are shown entirely (not truncated)
  3. Ensure you have Plus or Patron
  4. Tap "Preselect chapters"
  5. ✅ Chapters with more than 2 lines are shown entirely

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added this to the 7.79 milestone Dec 3, 2024
@leandroalonso leandroalonso requested a review from a team as a code owner December 3, 2024 21:35
@leandroalonso leandroalonso requested review from danielebogo and removed request for a team December 3, 2024 21:35
@leandroalonso
Copy link
Member Author

leandroalonso commented Dec 3, 2024

I will update CHANGELOG as soon as I figure if the current content is correct.

Updated.

@danielebogo I reordered the CHANGELOG and removed the unnecessary 7.80.

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leandroalonso ! It works

RocketSim_Screenshot_iPhone_16_6 1_2024-12-04_10 40 13

@danielebogo
Copy link
Contributor

@leandroalonso I'm wondering if we can also remove the 7.80 milestone

@leandroalonso
Copy link
Member Author

@danielebogo done! I also closed 7.77.1.

@leandroalonso leandroalonso merged commit 08be39a into trunk Dec 4, 2024
4 of 6 checks passed
@leandroalonso leandroalonso deleted the fix/chapter-cell-height branch December 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deselecting Chapters [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long chapter title get truncated
2 participants