Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UpNextShuffle] Add Toast message #2508

Merged
merged 2 commits into from
Dec 6, 2024
Merged

[UpNextShuffle] Add Toast message #2508

merged 2 commits into from
Dec 6, 2024

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Dec 5, 2024 •
edited
Loading

Fixes #2505

Adds a snackbar saying "Shuffle is on. Episodes will play in random order."

Context: p1733394295890409-slack-C07T08CTND9

To test

  • CI must be 🟢
  • Use a premium account
  • Go to UpNext and enable the Shuffle
  • Confirm you see the Toast being prompted

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.79 milestone Dec 5, 2024
@danielebogo danielebogo requested a review from a team as a code owner December 5, 2024 15:29
@danielebogo danielebogo requested review from SergioEstevao and removed request for a team December 5, 2024 15:29
SergioEstevao
SergioEstevao approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danielebogo danielebogo merged commit 940a6fd into trunk Dec 6, 2024
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/2505-display-toast-when-enable-shuffle branch December 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Projec] Up Next Shuffle
Projects
None yet
Milestone
7.79 ❄️
Development

Successfully merging this pull request may close these issues.

Up Next Shuffle - Add snackbar confirmation for when enabling shuffle
2 participants
@danielebogo @SergioEstevao