Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unarchive any bulk episodes marked as unplayed. #2713

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Unarchive any bulk episodes marked as unplayed. #2713

merged 2 commits into from
Jan 30, 2025

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 30, 2025 •
edited
Loading

| 📘 Part of: # |
|:---:|

Fixes #

This PR updates the bulk mark as played action to unarchive the episodes too

ScreenRecording_01-30-2025.11-42-03_1.MP4

To test

  1. Start the app
  2. Open a podcast
  3. Tap the option to show archive episodes
  4. Select some episodes
  5. Tap to mark them as played
  6. Tap to mark them as archived ( if needed)
  7. Now select the same episodes
  8. Select the option to mark as unplayed
  9. Check if the episodes are marked as unplayed an unarchived.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the [Type] Bug Used for issues where something is not functioning as intended. label Jan 30, 2025
@SergioEstevao SergioEstevao added this to the 7.82 milestone Jan 30, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 30, 2025 11:40
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team January 30, 2025 11:40
danielebogo
danielebogo approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!
It works!

@SergioEstevao SergioEstevao merged commit 5e1c819 into trunk Jan 30, 2025
5 of 7 checks passed
@SergioEstevao SergioEstevao deleted the fix/bulk_mark_as_played branch January 30, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

@bjtitus bjtitus Awaiting requested review from bjtitus bjtitus is a code owner automatically assigned from Automattic/pocket-casts-ios

Assignees
No one assigned
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.82
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @danielebogo