Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/html description resize #2717

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

Fixes a bug where background and foreground the podcast description caused a resize issue.

To test

  1. Start the app
  2. Open podcast
  3. Expand the description
  4. Background the app
  5. Foreground the app
  6. Check that the description stays with the correct size/layout

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the [Type] Bug Used for issues where something is not functioning as intended. label Jan 30, 2025
@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 30, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 30, 2025 21:41
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 30, 2025

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Member

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested trunk and was able to reproduce the issue, then in this branch the issue is gone! 🟢

One small thing, maybe you're already aware, I see some lines of the Severance podcast blinking:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-31.at.11.01.12.mp4

@SergioEstevao
Copy link
Contributor Author

One small thing, maybe you're already aware, I see some lines of the Severance podcast blinking:

Yeah it's something we are aware, the issue is that because of our use of WebKit we first need to show all lines before we clipped them, and because it all async calls you see this blink.

thanks for the review.

@SergioEstevao SergioEstevao merged commit e07678c into release/7.81 Jan 31, 2025
6 of 9 checks passed
@SergioEstevao SergioEstevao deleted the fix/html_description_resize branch January 31, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants