fix data source slug update in the form #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A bug was introduced in #195 where the slug field in the data source form wouldn't update properly under certain conditions. The bug occurred because the
SlugInput
component was comparing the sanitized slug with its local state instead of the form's state.Bug Details
The component would:
This caused the form state to retain old/empty values even when the user had entered valid input.
Steps to Reproduce
Fix
Modified the comparison to check against the form's slug prop instead of local state, ensuring form state updates correctly regardless of sanitization results.
Testing