Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Changes based on Walkthrough #213

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Documentation Changes based on Walkthrough #213

merged 3 commits into from
Nov 26, 2024

Conversation

smithjw1
Copy link
Contributor

@smithjw1 smithjw1 commented Nov 22, 2024

  • Fixed a typo on the hook implementation
  • Updated the allowed types based on this definition.

fixing a typo in the documentation
Adding proper types
- `type` (required): The type of the input variable. Supported types are `string`, `number`, and `boolean`.
- `type` (required): The type of the input variable. Supported types are:
- `base64`
- `boolean`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boolean isn't in the definition, but I figure it works.

@smithjw1
Copy link
Contributor Author

This PR will fix CAFE-1029, but I don't think I hooked Jira up correctly.

@smithjw1 smithjw1 marked this pull request as ready for review November 22, 2024 23:25
@smithjw1 smithjw1 merged commit 0c5f7e3 into trunk Nov 26, 2024
9 checks passed
@smithjw1 smithjw1 deleted the fix/typo branch November 26, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants