-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate store state with stepper navigation #3198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agreed. This sounds like overkill. |
# Conflicts: # includes/rest-api/class-sensei-rest-api-setup-wizard-controller.php
renatho
previously approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
Just a few comments about JSDoc.
It would be good in the future we take a look again in an eslint rule for that. I'll jot down here to see it at some moment.
Fixed JSDoc issues in 31e634c |
renatho
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3135
Changes proposed in this Pull Request
isFetching
starts withtrue
) - this saves a render with default data before the spinner is shownTesting instructions
sensei_setup_wizard_data
to start fresh?step=
query parameter)Not done here
?step=ready
). — This adds some complexity and issues so if it's not critical we could skip/delay it. Steps not yet available are not clickable, so this is not affecting any real-world use cases.