-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patterns filter by post type #5202
Add patterns filter by post type #5202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well! Some things I noticed with older WP versions but I think none are really important and we can "ignore" them being only minor visual things and for old WP versions.
Using WP 5.9.3
- Some previews are displayed with an excessively long height. Example:
Using WP 5.8.4
- Some previews are not displayed (not only for Sensei LMS but for all categories). Examples:
- Minor: Modal does not have a cross to close it. Clicking out of the modal or pressing escape works.
…sensei into add/patterns-filter-by-post-type
ae5d96e
to
7c182f1
Compare
Hey @aaronfc ! Thank you for your review!
I had noticed it and registered it as a known issue in: #5173. I mentioned that we could wait until the final patterns to see if it will happen, and if yes, we could explore that to see what workaround we could implement. One idea I had added there is set a maximum height to the thumbnails. Does it make sense for you? To make sure we don't forget it, I'm also adding it to a comment in this issue.
I thought it had gone away. 😞 Reopened this issue.
Good catch! Fixed in f22a70a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything clear!
Looks good and works well! 🚀
Fixes #5187
Changes proposed in this Pull Request
current_screen
hook to register the patterns based on the current post type. It wasn't really working on some beta versions, but it was fixed after the final release with this commit (basically, the server adds our registered patterns to the initial setup of the patterns - writing it in the HTML, and the other come later in the async fetch). Anyway, I asked for a confirmation here just to make sure I'm not missing anything.Testing instructions