-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "note shared" indicator to notes in the notes list #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo04
changed the title
Issue/1496 add shared icon note list
Add Shared Icon Indicator to Notes in the notes list
Sep 17, 2021
danilo04
changed the title
Add Shared Icon Indicator to Notes in the notes list
Add shared icon indicator to notes in the notes list
Sep 17, 2021
You can test the changes on this Pull Request by downloading the APK here. |
danilo04
changed the title
Add shared icon indicator to notes in the notes list
Add note shared icon indicator to notes in the notes list
Sep 17, 2021
danilo04
added
[Type] UX
UX Improvement
consistency
Issues created in order to align the UX with other platforms
[Type] Enhancement
Improve existing functionality.
labels
Sep 17, 2021
danilo04
changed the title
Add note shared icon indicator to notes in the notes list
Add "note shared" indicator to notes in the notes list
Sep 17, 2021
Use the local list of tags and verify whether there is an email in it to decide whether to show the the note shared indicator or not.
Looks good! Thanks @danilo04 |
SylvesterWilmott
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consistency
Issues created in order to align the UX with other platforms
[Type] Enhancement
Improve existing functionality.
[Type] UX
UX Improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1496.
Fix
Add the collaboration (note shared) icon to the notes list if the note has been shared by the user or to the user by another user.
Test
Note shared by the user
Collaborators
Note shared by another user
You need two accounts for this test. Let's call them Account A and Account B
Review
Only one developer and one designer are required to review these changes, but anyone can perform the review.
Release