Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "note shared" indicator to notes in the notes list #1499

Merged
merged 8 commits into from
Sep 24, 2021

Conversation

danilo04
Copy link
Contributor

@danilo04 danilo04 commented Sep 17, 2021

Fixes #1496.

Fix

Add the collaboration (note shared) icon to the notes list if the note has been shared by the user or to the user by another user.

Phone Light Phone Dark
Screenshot_20210917-115743_Simplenote Screenshot_20210917-115730_Simplenote
Tablet Light Tablet Dark
Screenshot_20210917-114831_Simplenote Screenshot_20210917-114923_Simplenote

Test

Note shared by the user

  1. Tap on a note
  2. Add an email to the tag list at bottom of the note
  3. Tap on the back icon (top left corner) to go to the notes list
  4. The note should have the shared icon
  5. Long tap on the note to pin it
  6. Now the note should have the pin and share icons
  7. Tap on the note
  8. Open right side menu (... dots) and tap on Collaborators
  9. Remove all the collaborators
  10. Go back to the note and then to the notes list
  11. The share note icon should not be shown for the note edited.

Note shared by another user

You need two accounts for this test. Let's call them Account A and Account B

  1. Login into account A
  2. Tap on a note
  3. Add the email of account B to the tag list at bottom of the note
  4. Logout from account A
  5. Login into account B
  6. The note shared by account A should

Review

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

@danilo04 danilo04 changed the title Issue/1496 add shared icon note list Add Shared Icon Indicator to Notes in the notes list Sep 17, 2021
@danilo04 danilo04 changed the title Add Shared Icon Indicator to Notes in the notes list Add shared icon indicator to notes in the notes list Sep 17, 2021
@peril-automattic
Copy link

peril-automattic bot commented Sep 17, 2021

You can test the changes on this Pull Request by downloading the APK here.

@danilo04 danilo04 changed the title Add shared icon indicator to notes in the notes list Add note shared icon indicator to notes in the notes list Sep 17, 2021
@danilo04 danilo04 self-assigned this Sep 17, 2021
@danilo04 danilo04 added [Type] UX UX Improvement consistency Issues created in order to align the UX with other platforms [Type] Enhancement Improve existing functionality. labels Sep 17, 2021
@danilo04 danilo04 changed the title Add note shared icon indicator to notes in the notes list Add "note shared" indicator to notes in the notes list Sep 17, 2021
@SylvesterWilmott
Copy link

Looks good! Thanks @danilo04

@danilo04 danilo04 merged commit 0ee5e6e into develop Sep 24, 2021
@danilo04 danilo04 deleted the issue/1496-add-shared-icon-note-list branch September 24, 2021 13:44
@danilo04 danilo04 modified the milestones: Future, 2.23 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Issues created in order to align the UX with other platforms [Type] Enhancement Improve existing functionality. [Type] UX UX Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note shared indicator in notes list
2 participants