Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to collaboration UI #1510

Merged
merged 18 commits into from
Sep 29, 2021
Merged

Improvements to collaboration UI #1510

merged 18 commits into from
Sep 29, 2021

Commits on Sep 27, 2021

  1. Add empty collaborators as empty view with the same format from tags

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    e4066e7 View commit details
    Browse the repository at this point in the history

  2. Fix warning in activity_tags layout

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    985939e View commit details
    Browse the repository at this point in the history

  3. Add Shared With message as the header of the recycler view 

    Since we are handling the empty view of the collaborators list with an
empty view, the Shared With message is now the header of a recycler view
and the data items are transformed to CollaboratorDataItem to submit the
list items.
    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    15a068a View commit details
    Browse the repository at this point in the history

  4. Move sealed class to bottom with other classes

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    34c4d6c View commit details
    Browse the repository at this point in the history

  5. Add SessionManager to provides the current user (auth or unauthorized)

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    cbcb02e View commit details
    Browse the repository at this point in the history

  6. Validate case in which the user tries to add themselves as collaborator

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    fab1fc8 View commit details
    Browse the repository at this point in the history

  7. Change error message

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    be79b3d View commit details
    Browse the repository at this point in the history

  8. Add blank end line for git

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    5da80b8 View commit details
    Browse the repository at this point in the history

  9. Add . to comments

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    9755220 View commit details
    Browse the repository at this point in the history

  10. Add test to validate whether the user is adding his account

    @danilo04
    danilo04 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    861478e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Add 4dp on image button to make a total of 16dp from right side

    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    aa2f314 View commit details
    Browse the repository at this point in the history

  2. Reduce 72dp to 16 dp in collaborator rows

    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    98189e5 View commit details
    Browse the repository at this point in the history

  3. Add collaborators menu to markdown fragment

    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    251e7e1 View commit details
    Browse the repository at this point in the history

  4. Reformat new files added in this PR

    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    6a898bb View commit details
    Browse the repository at this point in the history

  5. Refactor show and hiding empty view in recycler view 

    Avoid hardcoded parameters in method calls and improve code quality
    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9911340 View commit details
    Browse the repository at this point in the history

  6. Reformat layouts files to collapse certain tags

    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9aa1abb View commit details
    Browse the repository at this point in the history

  7. Add tests for SessionManager

    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c0c9db1 View commit details
    Browse the repository at this point in the history

  8. Keep old format in case

    @danilo04
    danilo04 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    675ed91 View commit details
    Browse the repository at this point in the history