Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case in delete account button in settings #1512

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Fix case in delete account button in settings #1512

merged 2 commits into from
Sep 29, 2021

Conversation

danilo04
Copy link
Contributor

@danilo04 danilo04 commented Sep 28, 2021 •
edited
Loading

Fixes #1511.

Fix

Following the format of titles in settings options, Delete Account should be changed to Delete account.

Settings Screen Delete account dialog
image image

Test

  1. Open the left panel and tap on Settings
  2. Scroll down and see Delete account
  3. Tap on Delete account option and see dialog

Review

Only one designer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated in f67e53a with:

Fixed case in delete account button in settings

@danilo04 danilo04 added consistency Issues created in order to align the UX with other platforms [Type] UX UX Improvement labels Sep 28, 2021
@danilo04 danilo04 added this to the 2.23 milestone Sep 28, 2021
@danilo04 danilo04 self-assigned this Sep 28, 2021
@peril-automattic
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@SylvesterWilmott
Copy link

Thanks @danilo04

@danilo04 danilo04 merged commit d887e3a into develop Sep 29, 2021
@danilo04 danilo04 deleted the issue/1511-fix-casting-delete-button branch September 29, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvesterWilmott SylvesterWilmott SylvesterWilmott approved these changes

Assignees

@danilo04 danilo04

Labels
consistency Issues created in order to align the UX with other platforms [Type] UX UX Improvement
Projects
None yet
Milestone
2.23
Development

Successfully merging this pull request may close these issues.

Fix casing on "Delete account" button in settings.
2 participants
@danilo04 @SylvesterWilmott