Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error handling in login to handle 429 response (too many wrong credentials at login) #1514

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Update error handling in login to handle 429 response (too many wrong credentials at login) #1514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7c1dad
Update error handling in login to add rate limit
danilo04 Sep 30, 2021
2684451
Update release notes
danilo04 Sep 30, 2021
13f70ef
Update simperium to last develop version
danilo04 Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Fixed crash when note reference is null in editor while hiding toolbar in landscape mode [#1504](https://github.com/Automattic/simplenote-android/pull/1504)
* [Internal] Updated list of tags to filter out collaborators (emails) [#1509](https://github.com/Automattic/simplenote-android/pull/1509)
* Fixed case in delete account button in settings [#1512](https://github.com/Automattic/simplenote-android/pull/1512)
* Added error handling for when the user has made too many wrong credential requests at login [#1514](https://github.com/Automattic/simplenote-android/pull/1514)

2.22
-----
Expand Down
2 changes: 1 addition & 1 deletion Simplenote/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ dependencies {
// Fastlane screengrab for screenshots automation
androidTestImplementation 'tools.fastlane:screengrab:2.0.0'
// Automattic and WordPress dependencies
implementation 'com.automattic:simperium:v1.0.0'
implementation 'com.automattic:simperium:develop-86ea7abdda7aece428ca5144a0a099b727b2473e'
implementation 'com.github.Automattic:Automattic-Tracks-Android:2.1.0'
implementation 'org.wordpress:passcodelock:2.0.2'

Expand Down
3 changes: 3 additions & 0 deletions ...src/main/java/com/automattic/simplenote/authentication/SimplenoteCredentialsActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ public void run() {
case UNVERIFIED_ACCOUNT:
showUnverifiedAccountDialog();
break;
case TOO_MANY_REQUESTS:
showDialogError(getString(R.string.simperium_too_many_attempts));
break;
case INVALID_ACCOUNT:
default:
showDialogError(getString(
Expand Down
1 change: 1 addition & 0 deletions Simplenote/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,4 +429,5 @@
<string name="simperium_not_now">Cancel</string>
<string name="simperium_change_password">Change Password</string>
<string name="simperium_okay">Okay</string>
<string name="simperium_too_many_attempts">Too many log in attempts. Try again later.</string>
</resources>