Skip to content

Commit

Permalink
Build: stop failing the build on eslint errors (#1594)
Browse files Browse the repository at this point in the history
`eslint` provides helpful warnings that prevent bugs in our software.
However by running it as a precondition for the build we introduce
artificial obstacles to quick testing and iteration. For instance, we
will fail to build the app if we have an unused variable even though
there's no reason it would break the build.

In this change we're removing the precondition for passing `eslint`
before building the app. This should allow us to more rapidly made small
debugging/testing adjustments while working on fixing or altering the
app.

`eslint` still belongs in the process and we might follow-up on this PR
by introducing it as a `git` hook on `precommit`, a more appropriate
place for the safety check. For now though I am foregoing that work in
order to remove what has been a persistent frustration while working on
the app.
  • Loading branch information
dmsnell authored Sep 27, 2019
1 parent 3090e09 commit 31e6bc7
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 97 deletions.
111 changes: 30 additions & 81 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"enzyme-adapter-react-16": "1.14.0",
"eslint": "6.1.0",
"eslint-config-prettier": "6.3.0",
"eslint-loader": "2.2.1",
"eslint-plugin-jest": "22.15.0",
"eslint-plugin-prettier": "3.1.1",
"eslint-plugin-react": "7.14.3",
Expand Down
15 changes: 0 additions & 15 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,6 @@ module.exports = () => {
},
module: {
rules: [
{
test: /lib\/.+\.jsx?$/,
exclude: /node_modules|lib\/simperium/,
enforce: 'pre',
use: [
{
loader: 'eslint-loader',
options: {
cache: true,
configFile: '.eslintrc.json',
quiet: true,
},
},
],
},
{
test: /\.jsx?$/,
exclude: /node_modules\/core-js/,
Expand Down

0 comments on commit 31e6bc7

Please sign in to comment.