Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: Selection is wrong, Markdown confuses RTL detection #2457

Open
ajmandourah opened this issue Nov 8, 2020 · 8 comments
Open

RTL: Selection is wrong, Markdown confuses RTL detection #2457

ajmandourah opened this issue Nov 8, 2020 · 8 comments
Labels
bug Something isn't working [feature] editor Anything related to the editor. i18n All things Internationalization

Comments

@ajmandourah
Copy link

ajmandourah commented Nov 8, 2020

  1. In Linux. RTL is not working as it should be. In comparison with windows version. Starting typing in Arabic will lead the text starting from the right (correct behavior) but starting with a "-" or like "##" will lead to this first symbol to be placed at left instead.
    Ex.
    Expected: عنوان ##
    Bugged : ## عنوان

  2. Mixing Arabic and English will lead to an issue while selecting the whole line. It basicly select an empty space in the left (while it actually the whole line is selected, can confirm by pressing backspace as the whole line deleted). This is confusing.

3 RTL in markdown doesn't work. (fixed in win and Mac)

manjaro vs windows
https://imgur.com/Khcfvl1

Reproduced

Reproduced by using Simplenote in any Linux distro

Where did you see the bug

Using Manjaro freshly installed.
Simplenote 2.0.0

a probably useful link using RLM and LRM
https://www.w3.org/TR/WCAG20-TECHS/H34.html
adding toggle button will probably satisfy the most
BoostIO/BoostNote-Legacy#3282

UPDATE:

After checking out it seems like I had an older version in windows. i tried up to version 1.21.1 and the arabic text appears right.
It seems like version 2.0.0 is bugged even in windows as texts appears strangly. check the image https://imgur.com/Khcfvl1

on right an older version and on the left version 2.0.0

@ajmandourah ajmandourah added the bug Something isn't working label Nov 8, 2020
@ajmandourah ajmandourah changed the title RTL issue in Linux Still issue with RTL in 2.0.0 Nov 10, 2020
@codebykat
Copy link
Member

Thanks for this, @ajmandourah. I'm wondering if the issues with selection also exist here:

https://microsoft.github.io/monaco-editor/playground.html

Would you mind testing and reporting back?

@codebykat
Copy link
Member

Noting lots of upstream issues about RTL support, the main ones seem to be:

microsoft/vscode#65648
microsoft/vscode#11770

@codebykat codebykat changed the title Still issue with RTL in 2.0.0 RTL: Selection is wrong, Markdown confuses RTL detection Nov 11, 2020
@ajmandourah
Copy link
Author

Thanks for this, @ajmandourah. I'm wondering if the issues with selection also exist here:

https://microsoft.github.io/monaco-editor/playground.html

Would you mind testing and reporting back?

To start with I use VSCode in writing an arabic webpage. Thw issue with the RTL exists but I feel its the best option available.

Regarding your link. first i belive its 2 separate issues mainly because in simplenote you have the option to completly go RTL when you first start writing in a RTL lang. this is not available in your link as it is basiclly a code editor .
by selection issue, I dont have any issue selecting letters in RTL neith LTR words. when selecting both in the same time I feel like the behavior is to be expected.

My main issue is with the formating while writing in RTL . see the uploaded image above. The right part is version 1.21.1 and this is the correct behavior. notice the position of the ":" . the left part is v 2.0.0

@rezzap
Copy link

rezzap commented Dec 8, 2020

There is another report of the selection issue in 3522477-zen . The issue happens when using CTRL+A but also in partially selecting.

It seems to work fine when it comes to copy/pasting, but the selecting part doesn't work as it should.

highlighting doesn't work but copying and pasting works fine. And when you try to partially select some RTL text the behavior is even more broken.

Screen Recording 2020-12-10 at 02 35 19 pm

Simplenote 2.0.0 web on Firefox v83.0 64bit on Manjaro Linux
Simplenote electron desktop app v2.2.0 on Manjaro Linux

@reginabally
Copy link

Another report in 3592831-zen.

Both Arabic and English cannot be aligned
Rather, Arabic goes to the right, and English goes to the left
There is also another problem in the Arabic language in particular
When "select all" the selection appears on the left side!

I'm able to replicate this on macOS Big Sur 11.1, Google Chrome Version 87.0.4280.88 (Official Build) (x86_64) on the web app. I'm also asking for the user's OS and browser version.

Screen Capture on 2020-12-23 at 10-11-23

@rossanafmenezes
Copy link

Another report in 3592831-zen.

Both Arabic and English cannot be aligned
Rather, Arabic goes to the right, and English goes to the left
There is also another problem in the Arabic language in particular
When "select all" the selection appears on the left side!

I'm able to replicate this on macOS Big Sur 11.1, Google Chrome Version 87.0.4280.88 (Official Build) (x86_64) on the web app. I'm also asking for the user's OS and browser version.

Screen Capture on 2020-12-23 at 10-11-23

User came back with the following info:

It happens with Windows 10
With the special installation of Windows
And also with all browsers:
Microsoft Edge - Google Chrome - Opera

It happens with many of my devices:

  • Dell OptiPlex OptiPlex 745_ Windows 10 Pro
  • Dell OptiPlex 9010_ Windows 10 Pro
  • Mac mini
  • Toshiba laptop_ Windows 10 Pro

It doesn't happen with Android or iOS app

@reginabally
Copy link

Also reported in 3315357-zen on the web app.

I am currently facing a problem that was not present before the latest update, namely dealing with notes in Arabic. They cannot be easily selected to be copied. In general, it is not possible to input a right-to-left text.

OS: macOS Catalina version 10.15.5
Browser: Google Chrome 87.0.4280.88 (Official Build) (x86_64) and Safari version 13.1.1 (15609.2.9.1.2)

@sandymcfadden sandymcfadden added the i18n All things Internationalization label Jan 18, 2021
@eduardozulian
Copy link
Member

Reported in 3818494-zen:

  • OS: Windows 7 x86
  • Simplenote 2.7.0-beta1

In the above ticket, there is a comprehensive video showing a few issues:

  • Cannot select text
  • Double-click to select doesn't work
  • Selecting all text shows the selection overlay in LTR instead
  • Some characters and not in the right place

The user claims it was fine before the last two updates

@codebykat codebykat added the [feature] editor Anything related to the editor. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [feature] editor Anything related to the editor. i18n All things Internationalization
Projects
None yet
Development

No branches or pull requests

7 participants