Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of trash tag button feels off #2891

Closed
pachlava opened this issue May 4, 2021 · 0 comments · Fixed by #2893
Closed

Position of trash tag button feels off #2891

pachlava opened this issue May 4, 2021 · 0 comments · Fixed by #2893
Labels
enhancement Improve existing functionality [priority] low Address this when there is time

Comments

@pachlava
Copy link
Contributor

pachlava commented May 4, 2021

What

When tags are sorted alphabetically, the position of trash tag button feels somewhat unpleasant:

Screenshot 2021-05-04 at 13 59 54

It feels like positioning it a bit to the left would be better

Why

Better UX
@pachlava pachlava added enhancement Improve existing functionality [priority] low Address this when there is time labels May 4, 2021
@sandymcfadden sandymcfadden mentioned this issue May 4, 2021
Merged
sandymcfadden added a commit that referenced this issue May 4, 2021
@sandymcfadden
Fix spacing on tag list edit buttons (#2893)
3fc1eab 
Fixes #2891

Currently, if you set to sort tags alphabetically and then choose to edit your tag list, the trash icon is hard up to the right side of the list.
If you have it set to manually sort tags then the reorder handle has spacing on the right.

This makes it more consistent and adds the spacing in either situation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing functionality [priority] low Address this when there is time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spacing on tag list edit buttons Automattic/simplenote-electron
1 participant
@pachlava