Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility for Revision Selector #980

Closed
mirka opened this issue Nov 1, 2018 · 0 comments · Fixed by #2707
Closed

Improve accessibility for Revision Selector #980

mirka opened this issue Nov 1, 2018 · 0 comments · Fixed by #2707
Assignees
@dcalhoun
Labels
accessibility Let's support _all_ of our users! NewMember

Comments

@mirka
Copy link
Member

mirka commented Nov 1, 2018

The RevisionSelector should act like a modal, in that:

  1. It should have role="dialog"
  2. It should be aria-hidden when not visible on screen
  3. Esc should close it
  4. Keyboard focus should jump to the first focusable element when the dialog is activated
  5. Keyboard focus should be trapped inside the dialog
  6. Keyboard focus should return to the original element when the dialog is closed
@mirka mirka added the accessibility Let's support _all_ of our users! label Nov 1, 2018
@bummytime bummytime mentioned this issue May 8, 2019
Closed
@codebykat codebykat mentioned this issue Dec 7, 2019
Closed
@dcalhoun dcalhoun mentioned this issue Mar 3, 2021
Merged
@dcalhoun dcalhoun self-assigned this Mar 3, 2021
sandymcfadden pushed a commit that referenced this issue Mar 20, 2021
@dcalhoun
Add focus trap to navigation sidebar (#2707)
0b2622c 
Fixes #979 and fixes #980. Improve navigation accessibility via the following:

- Add focus trap to navigation sidebar and revisions selector.
- Hide unrelated content while navigation sidebar or revisions selector is open.
- Reorder navigation elements to match visual presentation.
- Adjust styles to improve active focus indication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcalhoun dcalhoun

Labels
accessibility Let's support _all_ of our users! NewMember
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve navigation accessibility Automattic/simplenote-electron
3 participants
@dcalhoun @mirka @belcherj