Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never launch in fullscreen mode #1002

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Never launch in fullscreen mode #1002

merged 2 commits into from
Nov 20, 2018

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 10, 2018

Closes #739

Continuation of @rakhi2104's work from #904

This ensures that the app always launches with Fullscreen Mode disabled.

Due to a strange difference in behavior, a single approach was insufficient. After some experimentation, it turns out that we need to take a different approach depending on platform:

  • Mac → Disable fullscreen mode on window close
  • Win & Linux → Disable fullscreen mode on launch

To test

It would be better to test with the actual builds:

Steps

  1. Launch Electron app and set to Full Screen mode (View menu ▸ Toggle Full Screen)
  2. Quit app
  3. Relaunch app, and make sure that it is not in Full Screen mode

@roundhill
Copy link
Contributor

roundhill commented Nov 14, 2018

I've tested:

  • Linux
  • Mac
  • Windows (will get to it tomorrow!)

@roundhill
Copy link
Contributor

All 3 platforms now tested :shipit:

@mirka mirka merged commit c33e094 into master Nov 20, 2018
@mirka mirka deleted the fix/739-reset-fullscreen branch November 20, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset fullscreen mode to disabled when app is relaunched
3 participants