Fix incorrect labeling #1023
Merged
Fix incorrect labeling #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and Modified respectively
|
@tonytettinger Sorry, we're still tweaking the AppVeyor settings for forked PRs and the fail is not your fault! No worries 👍 |
mirka
reviewed
Nov 19, 2018
|
@mirka (Lena:), thank you very much for the quick response, I was trying to figure out the issue with the AppVeyor. I did the revert the changes on the package-lock.json file. I'm glad all is working well! |
mirka
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Thank you!
(By the way, I added a note to the pull request template so future contributors won't have to wonder what is going wrong 🙏)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix created for the issue #1003 .
The issue
Incorrect labels regarding creation and modification dates in Simplenotes.
Solution
Labels changed as per request in the modified files, both for the View Menu and the Settings Dialog:
Test
On the navigation tab open:
Both text should write Date Modified and Date Created.