Ensure that selected note is updated on launch when there are multiple updates #1093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a syncing bug I found while looking into #825.
Steps to reproduce
make dev
, log in to the same account in both Electron and in a browser.The pinned note title is updated in the note list, but not in the editor.
Cause
This bug was introduced with the importer feature, where we started to debounce the
noteUpdated
action for performance reasons. This could then prevent the currently selected note from updating in the editor, if the update event was one of the calls dropped by the debounce.Fix
Separate out the
loadNotes
call from theonNoteUpdate
function, and only debounce theloadNotes
call (contained inonNotesIndex
).