Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check before reselecting note in updateNoteContent #1141

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

mirka
Copy link
Member

@mirka mirka commented Jan 8, 2019

Closes #1125

This fixes an issue where a local change to a note's content would reselect that note in the Editor, even when the user had already navigated away to a different note.

To test

Test case from original issue

  1. Start a new note
  2. Type for a bit on it, then create a new note with the ctrl + N shortcut

↑ Do this quickly. Stop typing and immediately create a new note.

Another test case

  1. Type in a note.
  2. Immediately click on a different note.

@mirka mirka requested a review from roundhill January 8, 2019 10:11
@mirka mirka merged commit ee5c858 into master Jan 10, 2019
@mirka mirka deleted the fix/new-note-focus-race branch January 10, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: new note keyboard shortcut doesn't change focus to the new note
2 participants