Handle checkbox removal by backspace #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2019
roundhill
reviewed
Jan 16, 2019
lib/editor/checkbox-utils.js
Outdated
| ); | ||
| } | ||
|
|
||
| const firstHyphen = get(currentBlockText.match('-'), 'index', 0); |
There was a problem hiding this comment.
nit: how about naming this firstHyphenOffset or firstHyphenLocation?
roundhill
approved these changes
Jan 16, 2019
mirka
force-pushed
the
enhance/checkbox-removal
branch
from
3d0bf16 to
ee62ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1145