Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep editor in sync with selected note in NoteList #1220

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

mirka
Copy link
Member

@mirka mirka commented Feb 22, 2019

Based on #1218

This is a fix for an inconsistency in the UI state, where the selected note in the Note List (highlighted in blue) could get out of sync with the note shown in the editor.

There were at least two cases where this would occur:

  • Start searching for a note, and the editor will continue showing the initially selected note even when the query doesn't match it anymore.
  • When you switch from All Notes to the Trash view, the first trashed note is selected blue in the Note List, but the editor is blank.

@roundhill
Copy link
Contributor

  • Start searching for a note, and the editor will continue showing the initially selected note even when the query doesn't match it anymore.

This always bugged me, yay!

Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@mirka mirka force-pushed the fix/note-list-editor-sync branch from 745046d to 372362a Compare February 28, 2019 13:53
@mirka mirka changed the base branch from enhance/search-performance to master February 28, 2019 13:53
@mirka mirka merged commit 8e316af into master Feb 28, 2019
@mirka mirka deleted the fix/note-list-editor-sync branch February 28, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants