added styles for both light and dark theme to highlight note and chan… #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge colors for accessibility
|
@kchaplick I appreciate your attention to accessibility. We are currently in the midst of a colour audit and accessibility will be under the microscope. Regarding this PR, I think we should use a slightly lighter grey on dark mode for the background highlight but otherwise, it looks good! |
belcherj
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Approved, will address @SylvesterWilmott concerns in another PR
belcherj
pushed a commit
that referenced
this pull request
Aug 12, 2019
* Aria Label (#1400) * Added aria label for search field * Update dependency react-transition-group to v4.2.0 (#1421) * Update dependency concurrently to v4.1.1 (#1409) * Update dependency @material-ui/core to v4.1.3 (#1381) * Update dependency focus-visible to v5 (#1382) * Update dependency babel-eslint to v10.0.2 (#1388) * Update dependency eslint-config-prettier to v6 (#1408) * Update dependency eslint-plugin-react to v7.14.2 (#1406) * Update dependency eslint-plugin-jest to v22.7.1 (#1392) * Update dependency webpack-cli to v3.3.5 (#1405) * Fixes linting error (#1427) * Update dependency babel-plugin-dynamic-import-node to v2.3.0 (#1390) * Update dependency core-js to v3.1.4 (#1386) * Add check for local config over deve config (#1422) * Add deploy script and vip assets (#1429) * Update dependency lodash to v4.17.13 [SECURITY] (#1444) * Update dependency draft-js to v0.11.0 (#1443) * Update dependency redux to v4.0.4 (#1441) * Pin dependencies (#1445) * added styles for both light and dark theme to highlight note and change colors for accessibility (#1402) * Fix the develop build * Remove simperium link from about page (#1450) * Updates dark mode note list styling (#1452) * Updates dark mode note list styling * Switch blue background to grey for dark mode * Update version for 1.7.0-beta1 * Fixes public path for electron * Bump version to 1.7.0-beta2 * Bump version to 1.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge colors for accessibility
Fix
Changed the note selected blue to a more accessible color on light and dark mode. Changed the text and pinner colors to be more accessible based on new selection color.
#1397
Test
Review
Only one developer and one designer are required to review these changes, but anyone can perform the review.