Updates log in and sign up styling in Electron app #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bummytime
requested changes
Jul 31, 2019
There was a problem hiding this comment.
This is looking good great @belcherj. I noticed 2 small nits:
1) The or span appears to be the highest z-order element so it will float above things like the about or settings dialogs:
2) The login error text changes when navigating in-between sign in and log in. I think in this situation we should probably clear the error:
Other than these 2 things, I think it looks great!
bummytime
approved these changes
Jul 31, 2019
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Closes: #1458
Updates the styling of the Log in and Sign up screens
Test
npm run devReview
Only one developer and one designer are required to review these changes, but anyone can perform the review.
Release
CHANGELOG.txtwas updated with:- Updated Log in and Sign up form to match current styling