Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login screen: Replace hardcoded CSS colors with Color Studio as per design guidelines #1612

Merged
merged 3 commits into from
Oct 4, 2019

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Oct 2, 2019

The auth screen colors were mostly defined as pure CSS. This PR replaces them with Color Studio colors as per the design guidelines.

The changes are most drastic in dark mode.

Screenshots

Light Mode Before:

Screen Shot 2019-10-01 at 7 01 42 PM

Screen Shot 2019-10-01 at 7 01 46 PM

Light Mode After:

Screen Shot 2019-10-01 at 7 03 44 PM

Screen Shot 2019-10-01 at 7 03 41 PM

Dark Mode Before:

Screen Shot 2019-10-01 at 7 01 54 PM

Screen Shot 2019-10-01 at 7 02 01 PM

Dark Mode After:

Screen Shot 2019-10-01 at 7 03 57 PM

Screen Shot 2019-10-01 at 7 03 53 PM

Test

Build the Electron app and view its login/sign up screen.

Release

RELEASE-NOTES.txt was updated in 7b57bc6 with a link to this PR.

@codebykat codebykat self-assigned this Oct 2, 2019
@codebykat codebykat changed the title Login screen: Replace defined CSS colors with Color Studio as per design guidelines Login screen: Replace hardcoded CSS colors with Color Studio as per design guidelines Oct 2, 2019
@codebykat
Copy link
Member Author

@SylvesterWilmott I am troubled by how different the shade of blue originally was for the login with WPCOM button -- is it supposed to be different than our "brand blue"? Pls advise

@belcherj
Copy link
Contributor

belcherj commented Oct 2, 2019

Well, the colors being hardcoded is totally my fault. I wanted to start using the new colors but didn't want to change all the colors on the site.

@SylvesterWilmott
Copy link
Contributor

It looks great @codebykat thanks!

I am troubled by how different the shade of blue originally was for the login with WPCOM button -- is it supposed to be different than our "brand blue"? Pls advise

We should use the WP brand blue for this button specifically WordPressBlue50

Otherwise, just one minor change:

  • Input placeholder text (Dark): gray20

Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@codebykat codebykat merged commit 1aa381c into develop Oct 4, 2019
@codebykat
Copy link
Member Author

Fixed up the WPCC button background and the input placeholder colors for dark mode, merged 👍

@codebykat codebykat deleted the fix/auth-screen-colors branch October 4, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants