Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus-mode transition to small screen #1763

Merged
merged 2 commits into from
Dec 7, 2019
Merged

Fix focus-mode transition to small screen #1763

merged 2 commits into from
Dec 7, 2019

Conversation

qualitymanifest
Copy link
Contributor

@qualitymanifest qualitymanifest commented Dec 6, 2019

Fix

Closes #1760

When resizing to small screen, if focus mode is enabled, keep the note open

Test

  1. Open a note in full screen
  2. Enable focus mode
  3. Resize window small enough that isSmallScreen is true. See that note is still open, instead of switching to note-list

Review

See steps above

Release

RELEASE-NOTES.txt was updated in 9a15ac1 with:

Keep note open when transitioning to small screen in focus mode

@codebykat
Copy link
Member

This is great, thanks so much for the fix @qualitymanifest !

@codebykat codebykat merged commit af81052 into Automattic:develop Dec 7, 2019
@codebykat codebykat added this to the 1.14 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive: Resizing with sidebar hidden should start in note focus
2 participants