App-state: Remove unused indexCtr
#1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebykat
approved these changes
Dec 31, 2019
There was a problem hiding this comment.
👍
As an aside, do we really need release notes for very minor code clean-up that doesn't create any user-facing changes? My instinct would have been to skip it but I don't know if we have a hard-and-fast rule about what changes "require" release notes. cc @bummytime
My plan was to incorporate all of the random cleanups into this one line. We might need to do a PR to cleanup the release notes before the next release though. |
In the earlier stages of the app we relied on counting index operations to defer updating the internal note list. This was to prevent thrashing in the app when receiving updates for an account with lots of notes. In #89 we moved the `indexCtr` value out of the controlled app state and turned it into an instance variable on the `actionMap` object. This change was made because we couldn't wait for a Redux update cycle to update that value - the instance property updated immediately and imperatively. In #987 we removed the index-counting operation entirely and instead relied on a more natural `debounce()` on `bucket.on('index')`. This removed the need for the work-around but didn't remove the `indexCtr` property. In this patch we're finally removing it to finish the work from #987. The property is currently unused and unreferenced in the app.
dmsnell
force-pushed
the
refactor/remove-unused-counter
branch
from
9ecd37d to
d7e4ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the earlier stages of the app we relied on counting index operations
to defer updating the internal note list. This was to prevent thrashing
in the app when receiving updates for an account with lots of notes.
In #89 we moved the
indexCtrvalue out of the controlled app state andturned it into an instance variable on the
actionMapobject. Thischange was made because we couldn't wait for a Redux update cycle to
update that value - the instance property updated immediately and
imperatively.
In #987 we removed the index-counting operation entirely and instead
relied on a more natural
debounce()onbucket.on('index'). Thisremoved the need for the work-around but didn't remove the
indexCtrproperty.
In this patch we're finally removing it to finish the work from #987.
The property is currently unused and unreferenced in the app.
Testing
There should be no functional or visual changes in this patch.