Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dependencies #1802

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Update Dependencies #1802

merged 3 commits into from
Jan 3, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Jan 2, 2020 •
edited
Loading

Fix

Updates Dependencies

Test

Run app and click around.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Updated dependencies #1802

@belcherj belcherj requested a review from a team January 2, 2020 21:00
@belcherj belcherj self-assigned this Jan 2, 2020
dmsnell
dmsnell reviewed Jan 2, 2020
View reviewed changes
dmsnell
dmsnell reviewed Jan 2, 2020
View reviewed changes
dmsnell
dmsnell requested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that we're updating electron in another PR, but for this one can we leave webdriverio and spectron as-is so we don't introduce a commit with mismatched testing libraries?

@belcherj belcherj merged commit 53d38e2 into develop Jan 3, 2020
@belcherj belcherj deleted the update/dependencies branch January 3, 2020 17:04
@codebykat codebykat added this to the 1.14 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell requested changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@belcherj @dmsnell @codebykat