Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #1993

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Update Dependencies #1993

merged 1 commit into from
Apr 14, 2020

Conversation

belcherj
Copy link
Contributor

Fix

Update most dependencies

Test

  1. Need to run the checklist

Release

Note updated: Updated dependencies

@belcherj belcherj requested a review from a team April 13, 2020 16:24
@belcherj belcherj self-assigned this Apr 13, 2020
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to html-webpack-plugin look benign and even advantageous, primarily because we use so many of its defaults already

@dmsnell
Copy link
Member

dmsnell commented Apr 14, 2020

At some point we should circle back to the html-webpack-plugin updates because it looks like we can create a React component to produce that, which might make some things easier to maintain, especially if we want to ship an empty app shell vs. an empty HTML page

@belcherj belcherj merged commit 8ba7a95 into develop Apr 14, 2020
@belcherj belcherj deleted the update/dependencies branch April 14, 2020 14:24
@dmsnell dmsnell added this to the 1.16 milestone Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants