Added armv7l and arm64 build targets to Linux build

[rschouwenburg]

Fix

Add Linux armv7l and arm64 build target support for Linux build. Standard Linux build environment worked for me. I build on Ubuntu LTS 18.0.4.3 x64 and tested build packages on arm64 (Pinebook Pro running Manjaro 20.04) and armv7l (Raspberry Pi running Debian 10.3).

PR asked for by @dmsnell on #1986

Test

Linux build now creates armv7 and arm64 packages:

make package-linux

Release

Simplenote now supports armv7l (aka armhf on Debian) and arm64 platforms

[dmsnell]

@nsakaimbo would you be willing to give this a review?

[belcherj]

I am happy with these changes. By providing these builds we will not necessarily be testing releases on arm based systems.

[belcherj]

We will need to see if this builds before merging.

[nsakaimbo]

The change looks straightforward enough - couldn't find arm7l in the Electron docs, but it is in the electron-builder code https://github.com/electron-userland/electron-builder/blob/cd28eb093f0bf5969ad87c64773cc0714dc8d8ea/packages/builder-util/src/arch.ts.

To echo what @belcherj said, as long as there are clear expectations around debugging/troubleshooting issues that come up on these specific platforms then should be fine. (From time-to-time there are platform-specific issues that arise when trying to build or run any specific variant, so if we're willing to accept the maintenance overhead as well then LGTM.)

👍

[belcherj]

The build succeeded.

[valiant66]

I'm just an end user, not a coder.

I've tried installing Simplenote onto my Raspberry Pi Four using Snap and gdebi. Both throw "not available on stable for this architecture" type errors.

I know very little about git.

a. Is there an unstable version of Simplenote that runs on Raspberry Pi Four?
b. where would I turn to learn how to install it.

THanks

[belcherj]

The next release will have arm versions available. The releases are available here: https://github.com/Automattic/simplenote-electron/releases

The betas currently there are pretty stable.

We do not have access to arm devices for testing or have knowledge of installing on Raspberry Pi Four

[rschouwenburg]

Excellent news! Thank you!

I did some testing on both Raspberry Pi (deb, armv7l) and Pinebook Pro (AppImage, arm64) and both versions work. I tried most common activities and everything works as expected. I did encounter a couple of bugs but I do not know if they are related to the 1.7 beta or the arm platform builds. None of these bugs were present in 1.15.1 I compiled on myself on these platforms.

Let me know how you would like to go about this? I am happy to try to fix any arm platform related bugs but I rather wait until I can get my hands on a stable version if that makes sense.

[belcherj]

@rschouwenburg I think opening a new issue is the best bet! Let us know what the bugs are and we can figure out the cause.